Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove flaky status for cluster test #3975

Closed
wants to merge 1 commit into from
Closed

test: remove flaky status for cluster test #3975

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 23, 2015

The test did not fail after 9999 runs in continuous integration. https://ci.nodejs.org/job/node-stress-single-test/28/nodes=armv7-wheezy/console

Remove it's flaky status.

Fixes: #2557

@cjihrig
Copy link
Contributor

cjihrig commented Nov 23, 2015

LGTM

@Trott Trott mentioned this pull request Nov 23, 2015
Closed
@Trott Trott added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Nov 23, 2015
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Nov 23, 2015
@bnoordhuis
Copy link
Member

Another LGTM.

@r-52
Copy link
Contributor

r-52 commented Nov 23, 2015

LGTM

@rvagg
Copy link
Member

rvagg commented Nov 24, 2015

lgtm, for good measure

@Trott
test: remove flaky status for cluster test
0ff1ba4 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: nodejs#2557
Trott added a commit that referenced this pull request Nov 24, 2015
@Trott @r-52
test: remove flaky status for cluster test
6588422 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@r-52
Copy link
Contributor

r-52 commented Nov 24, 2015

Thanks @Trott ! Landed in 6588422

@r-52 r-52 closed this Nov 24, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
Closed
Trott added a commit that referenced this pull request Dec 1, 2015
@Trott
test: remove flaky status for cluster test
45e27d1 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this pull request Dec 4, 2015
@Trott @rvagg
test: remove flaky status for cluster test
950af45 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this pull request Dec 5, 2015
@Trott @rvagg
test: remove flaky status for cluster test
a863e8d 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
Trott added a commit that referenced this pull request Dec 17, 2015
@Trott @jasnell
test: remove flaky status for cluster test
b2f1014 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this pull request Dec 23, 2015
@Trott @jasnell
test: remove flaky status for cluster test
eb95182 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@Trott Trott deleted the cluster-flaky branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @cjihrig @bnoordhuis @r-52 @rvagg @mscdex @jasnell @MylesBorins